[FIX] model: CoreViewPlugin leaves core on revision replay #5068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreViewPlugins receive remote messages and while replaying them locally, they can re-dispatch sub-commands. Currently, the plugin will re-dispatch using the 'global'
Model.dispatch
method which is the external entry point of Model and creates a new local history step when called.This means that the coreViewPlugin can create new history steps when replaying a remote command, which ends up with their local changes sent to the network.
Two notes on that subject:
This revision adapts the dispatch of CoreViewPlugin such that they bypass the local history (and thus revision creation) when replaying remote revisions.
Task: 4241403
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist