[FIX] clipboard: Fix clipboard cross-browser coverage #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
commented
Oct 8, 2024
rrahir
force-pushed
the
18.0-fix-cross-browser-rar
branch
2 times, most recently
from
97b7c6c
to
9f6b1ec
Compare
hokolomopo
reviewed
Oct 10, 2024
| const oSheetClipboardData = htmlDocument | ||
| .querySelector("div") | ||
| ?.getAttribute("data-osheet-clipboard"); |
There was a problem hiding this comment.
Just curious: are there any pro/cons of parsing the HTML rather than using a regex ? And of putting the data in an attribute rather than a HTML comment ?
rrahir
force-pushed
the
18.0-fix-cross-browser-rar
branch
3 times, most recently
from
36e3e98
to
dd74a9a
Compare
The current implementation of the cross-browser clipboard relies heavily on an API that is currently only available on Chromium based browsers (see [table](https://developer.mozilla.org/en-US/docs/Web/API/Clipboard_API#api.clipboarditem)). There is currently no definitive announce that the feature will be adopted by other browsers (namely FF and Safari) and since the feature is still marked as experimental, it'd be better to rely ona more generic approach. This revision changes the flow to rely entirely on the `text/html` mimetype as it is supported by all modern browsers. Task: 4241877
rrahir
force-pushed
the
18.0-fix-cross-browser-rar
branch
from
dd74a9a
to
da28d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the cross-browser clipboard relies heavily on an API that is currently only available on Chromium based browsers (see table).
There is currently no definitive announce that the feature will be adopted by other browsers (namely FF and Safari) and since the feature is still marked as experimental, it'd be better to rely on a more generic approach.
This revision changes the flow to rely entirely on the
text/htmlmimetype as it is supported by all modern browsers.Task: 4241877
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist