[IMP] charts: allow to reorder data series #5027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Sep 30, 2024
tests/pivots/spreadsheet_pivot/__snapshots__/spreadsheet_pivot_side_panel.test.ts.snap
Show resolved
Hide resolved
anhe-odoo
force-pushed
the
master-selection_input-allow_reordering-anhe
branch
from
8e8145a
to
81c6192
Compare
Task Description This task aims to add the possibility to reorder the ranges in the selection input, allowing then the user to change the order of the data series. Related Task Task: 3994495
Task: 3994495
anhe-odoo
force-pushed
the
master-selection_input-allow_reordering-anhe
branch
from
81c6192
to
f4da0f1
Compare
hokolomopo
reviewed
Oct 22, 2024
| @@ -119,6 +119,13 @@ export class GenericChartConfigPanel extends Component<Props, SpreadsheetChildEn | |||
| }); | |||
| } | |||
|
|
|||
| onDataSeriesReordered(indexes: number[]) { | |||
There was a problem hiding this comment.
Is there a reason we have the SelectionInput return an array of index for this callback rather that the final array of ranges ?
From ouside the component, it'd be easire to reaceive an array of range. We could then use onDataSeriesRangesChanged for both props onSelectionReordered and onSelectionChanged. Or is there a reason it doesn't work ?
There was a problem hiding this comment.
I did it that way because we have to reorder the ranges and the corresponding properties, and we have to differentiate when the user manually change the ranges and when he reordered it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
This task aims to add the possibility to reorder the ranges in the selection input, allowing then the user to change the order of the data series.
Related Task
review checklist