Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] charts: limit trending line degree range #5022

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[IMP] charts: limit trending line degree range #5022

wants to merge 1 commit into from

Conversation

anhe-odoo
Copy link
Contributor

Task Description

This task aims to add a maximum value for the trending line degree (for a polynomial model), fixed to the minimum value of 10 and 1 below of the number of point in the series.

Related Task

  • Task: 4207820

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Sep 24, 2024

Pull request status dashboard

hokolomopo
hokolomopo reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tchou tchou 🚂

src/components/side_panel/chart/chart_with_axis/design_panel.ts Show resolved Hide resolved
src/components/side_panel/chart/chart_with_axis/design_panel.ts Outdated Show resolved Hide resolved
src/components/side_panel/chart/chart_with_axis/design_panel.ts Show resolved Hide resolved
@anhe-odoo anhe-odoo force-pushed the master-chart-fix_trending_line_degree-anhe branch 2 times, most recently from dd2616f to 39f9a65 Compare September 30, 2024 08:40
@anhe-odoo
[IMP] charts: limit trending line degree range
ed12e2b 
Task Description

This task aims to add a maximum value for the trending line degree
(for a polynomial model), fixed to the minimum value between 10
and 1 below the number of points in the series.

Related Task

Task: 4207820
@anhe-odoo anhe-odoo force-pushed the master-chart-fix_trending_line_degree-anhe branch from 39f9a65 to ed12e2b Compare October 21, 2024 10:54
@anhe-odoo anhe-odoo changed the base branch from master to 18.0 October 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokolomopo hokolomopo hokolomopo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anhe-odoo @robodoo @hokolomopo