-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include return progress arg #76
Conversation
jobdir added to the response of nb2service for running jobs by oda-hub/nb2workflow#129 |
First round of review, mainly to understand if something is missing. a small change in the dispatcher oda-hub/dispatcher-app#632 will also be needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice overall.
We need to agree on how this is treated by both frontend and oda_api to properly structure the dispatcher response, so we can get rid of unneded product methods (e.g. we don't really required to save this notebook representation into file with write
if there won't be a "download" button)
Edge cases:
|
Seems so, finally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one fix and cool overall!
I only wonder how the response will then be used on the frontend side. We have full page html in json, how to show it there?
Co-authored-by: Volodymyr <volodymyrss@users.noreply.github.com>
No description provided.