-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crop] use video-crop instead of inserting lavf crop #70
base: master
Are you sure you want to change the base?
Conversation
That's a cool change, should also be much faster than applying a lavf filter. I think I will only merge the PR after the next mpv release though, since this is a breaking change. Ideally |
Beware that this breaks one of crop.lua's unique feature – recursive cropping. |
Merges occivink/mpv-scripts#70 This change will break some major features, notably recursive cropping and thumbfast's preview. But for now, I think these are acceptable trade-offs.
It is possible to support in script, but instead stacking |
Based on occivink#70 - Support recursive `video-crop` and `zoom-pan` - zoom-pan (soft) can now be toggled - Added remove-crop: - `remove-crop [{type}]` - Removes all filters starting with delogo. If `{type}` is specified it removes only filters of that type (hard, delogo, soft). - `remove-crop all [{type}]` - Removes all filters starting with specified type. If no type is specified it removes all filters. - `remove-crop all order` - Removes filters starting with the most recently added.
Based on occivink#70 - Support recursive `video-crop` and `zoom-pan` - zoom-pan (soft) can now be toggled - Added remove-crop: - `remove-crop [{type}]` - Removes all filters starting with delogo. If `{type}` is specified it removes only filters of that type (hard, delogo, soft). - `remove-crop all [{type}]` - Removes all filters starting with specified type. If no type is specified it removes all filters. - `remove-crop all order` - Removes filters starting with the most recently added.
Depends on: mpv-player/mpv#12246
This will allow cropping while using hardware decoding. I'll clean this up a bit when the mpv PR is merged