[crop] Add light curtain to make out selection in dark areas #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
occivink
reviewed
Sep 18, 2022
| @@ -231,7 +232,8 @@ function draw_crop_zone() | |||
| top_left = { x = 0, y = 0 }, | |||
| bottom_right = { x = dim.w, y = dim.h }, | |||
| } | |||
| draw_shade(ass, frame, window) | |||
| if opts.light_opacity:lower() ~= "ff" then draw_shade(ass, frame, window, "FFFFFF", opts.light_opacity) end | |||
| if opts.light_opacity:lower() ~= "ff" then draw_shade(ass, frame, window, "000000", opts.shade_opacity) end | |||
There was a problem hiding this comment.
the condition should be on shade_opacity. Maybe make that an early return in draw_shade() instead
|
Looks good. Please add the new option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was impossible to see the crop selection over dark backgrounds.
Adds another bright "shade" to remedy it.
Default
shade_opacityhas been updated to keep a similar brightness to before the change.