Disable hardware decoding when using blur_edges #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would make sense to make this behavior configurable, and simply just warn and abort by default. |
At least on my system it also doesn't work with the -copy versions. I made it configurable and documented it in the config file. I mad it enable by default, since if it is set to false the script will likely not work for several users, without any benefit. |
|
This would be very nice to have for crop.lua as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware decoding will most often interfer with the filter, therefore disable
it when enabling of blur_edges and restore the original value when disabling.
If you think it would be better to implement this feature as an opt-in/opt-out
feature let me know.