-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release mod 1.0 #26296
base: master
Are you sure you want to change the base?
Release mod 1.0 #26296
Conversation
dev-repo: "git+https://gitlab.com/v0g/mod.git" | ||
url { | ||
src: | ||
"https://gitlab.com/-/project/60374965/uploads/baf2217bcdcb1a66362ab6aa82c0fdf1/mod-1.0.tar.zst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opam is unable to unpack this file
It would be useful either in the library or in the opam file description (or both) to explain what does it mean that they are proper modulo operators and how to use them, especially for a 1.0 release. |
@vog have you had a chance to look at the above? Happy to help with any questions you have about opam, if any, but you need to make the decisions about your own package. |
Thanks for your feedback. I'll add an explanation. However, I don't understand what you mean by "opam is unable to unpack this file". I just tested it by hand on a plain Debian system, where I can download and unpack the source archive without any errors or warnings:
|
@vog You can see the error in our CI here https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/e0e9c62df312c7a170343e5119054fa24510f25a/variant/compilers,4.14,mod.1.0 E.g.,
opam doesn't support the zst compression format currently. Thanks to this PR, we have planned work now to specify this in the manual (see ocaml/opam#6171), but you can currently see the supported formats here: https://github.com/shonfeder/opam/blob/main/src/core/opamSystem.ml#L830-L853 |
Hello, taking a look at the interface file here: https://gitlab.com/v0g/mod/-/blob/main/src/lib/Mod.mli?ref_type=heads It seems like there are no docstrings (nor readme file), would you mind adding some docstrings that people could refer to? The reason I mention this is because publishing on the opam-repository will trigger the documentation to be built and served in the OCaml website. So it would be helpful if there was some documentation in the module. |
No description provided.