Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] lambdapi (2.5.1) #26270

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

fblanqui
Copy link
Contributor

Proof assistant for the λΠ-calculus modulo rewriting

CHANGES:

Added

  • Add export format raw_dk.
  • Fix of the color of the text in command line when console.out is used.
  • Use black text instead of red when diplaying query answers.
  • Allow negative numbers in notation priorities.
  • New release 0.2.2 of the VSCode plugin.

CHANGES:

### Added

- Add export format `raw_dk`.
- Fix of the color of the text in command line when console.out is used.
- Use black text instead of red when diplaying query answers.
- Allow negative numbers in notation priorities.
- New release 0.2.2 of the VSCode plugin.
@shonfeder
Copy link
Collaborator

Hello! Thanks for the update :)

I see a failure on arm32-ocaml-5.2 and x86_32-ocaml-5.2 (other platforms are ok)

[ERROR] The compilation of lambdapi.2.5.1 failed at "dune build -p lambdapi -j 79 @install".

#=== ERROR while compiling lambdapi.2.5.1 =====================================#
# context              2.3.0~alpha~dev | linux/arm32 | ocaml-base-compiler.5.2.0 | pinned(https://github.com/Deducteam/lambdapi/releases/download/2.5.1/lambdapi-2.5.1.tbz)
# path                 ~/.opam/5.2/.opam-switch/build/lambdapi.2.5.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lambdapi -j 79 @install
# exit-code            1
# env-file             ~/.opam/log/lambdapi-7-393e6d.env
# output-file          ~/.opam/log/lambdapi-7-393e6d.out
### output ###
# File "src/cli/dune", line 2, characters 7-15:
# 2 |  (name lambdapi)
#            ^^^^^^^^
# Error: No rule found for src/cli/lambdapi.exe

Looking at the source and other platforms building correctly, I'm not immediately sure why dune would fail to find the src/cli/lambdapi.ml here. 😕

@mseri
Copy link
Member

mseri commented Jul 25, 2024

I was looking into it as well, and I don't really know. It fails on bytecode-only targets, but why I can't understand

@fblanqui
Copy link
Contributor Author

fblanqui commented Jul 25, 2024

@mseri
Copy link
Member

mseri commented Jul 26, 2024

Only the 32 bit errors are to be understood, the rest is fine.

And I know why it fails! You are building both native and bytecode executable always. But those platforms are bytecode only, so the build fails trying to make a native executable

"@doc" {with-doc}
]
]
available: arch != "ppc64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
available: arch != "ppc64"
available: arch != "ppc64"
conflicts: [ "ocaml-option-bytecode-only" ]

are you sure ppc64 is still needed there and it was not also a failure of the same type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't know. I'm going to update the PR to check this.

@fblanqui
Copy link
Contributor Author

Hi. Is it ok now or should I make other changes?

@mseri mseri merged commit 7c4ff52 into ocaml:master Jul 29, 2024
1 of 3 checks passed
@mseri
Copy link
Member

mseri commented Jul 29, 2024

Looks good, thanks

@fblanqui fblanqui deleted the release-lambdapi-2.5.1 branch July 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants