Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlcuddidl.3.0.8 #26112

Merged
merged 1 commit into from
Jul 9, 2024
Merged

mlcuddidl.3.0.8 #26112

merged 1 commit into from
Jul 9, 2024

Conversation

nberth
Copy link
Contributor

@nberth nberth commented Jun 18, 2024

Adds support for building native plugins

@nberth nberth force-pushed the mlcuddidl.3.0.8 branch 5 times, most recently from 1f9cd13 to c5a7bec Compare June 19, 2024 07:09
@nberth nberth marked this pull request as ready for review June 19, 2024 19:00
@avsm
Copy link
Member

avsm commented Jun 23, 2024

Fallout for camlidl for the caml.inria.fr server being down, but also some C pointer conversion warnings with newer glibc. Do you want to look over those @nberth?

@nberth
Copy link
Contributor Author

nberth commented Jun 27, 2024

Fallout for camlidl for the caml.inria.fr server being down, but also some C pointer conversion warnings with newer glibc. Do you want to look over those @nberth?

@avsm Sure!
Updated specifications for camlidl are available in PR #26138.
The warning about pointer conversion is actually due to some code generated by camlidl itself. I tried working that around, but did not really obtain anything cleaner without a warning appearing somewhere. Fixing this properly may actually require somme changes in camlidl (which hardcodes some assignements to NULL without any means to cast). The code involved is about propagating exceptions thrown by callbacks into OCaml, that we have to intercept at the C level to deal with CUDD's memory management, and then re-raise. camlidl may be too limited when it comes to manipulating exception values.

Adds support for building native plugins
@mseri
Copy link
Member

mseri commented Jul 9, 2024

Thanks. If the compiler issue is fixed in camlidl, I guess this will automatically start working in the two remaining systems

@mseri mseri merged commit a9cd097 into ocaml:master Jul 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants