Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirage-crypto-pk 0.6* 0.7* 0.8.0: restrict to eqaf < 0.10 #26107

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jun 17, 2024

this is a second part of fixing the revdeps of #26094

I didn't bother restricting mirage-crypto-pk (or mirage-crypto-ec) > 0.8.0, since mirage-crypto itself is adjusted to require eqaf < 0.10 from that version on, and the mirage-crypto-{pk,ec} require mirage-crypto with =version.

=== ERROR while compiling mirage-crypto-pk.0.8.0 =============================#
 context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
 path                 ~/.opam/4.14/.opam-switch/build/mirage-crypto-pk.0.8.0
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p mirage-crypto-pk -j 255
 exit-code            1
 env-file             ~/.opam/log/mirage-crypto-pk-7-5cecb4.env
 output-file          ~/.opam/log/mirage-crypto-pk-7-5cecb4.out
 ## output ###
 File "pk/dune", line 4, characters 68-80:
 4 |   (libraries cstruct zarith mirage-crypto mirage-crypto-rng sexplib eqaf.cstruct rresult)
                                                                         ^^^^^^^^^^^^
 Error: Library "eqaf.cstruct" not found.
 -> required by library "mirage-crypto-pk" in _build/default/pk
 -> required by _build/default/META.mirage-crypto-pk
 -> required by _build/install/default/lib/mirage-crypto-pk/META
 -> required by _build/default/mirage-crypto-pk.install
 -> required by alias install

```
=== ERROR while compiling mirage-crypto-pk.0.8.0 =============================#
 context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
 path                 ~/.opam/4.14/.opam-switch/build/mirage-crypto-pk.0.8.0
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p mirage-crypto-pk -j 255
 exit-code            1
 env-file             ~/.opam/log/mirage-crypto-pk-7-5cecb4.env
 output-file          ~/.opam/log/mirage-crypto-pk-7-5cecb4.out
 ## output ###
 File "pk/dune", line 4, characters 68-80:
 4 |   (libraries cstruct zarith mirage-crypto mirage-crypto-rng sexplib eqaf.cstruct rresult)
                                                                         ^^^^^^^^^^^^
 Error: Library "eqaf.cstruct" not found.
 -> required by library "mirage-crypto-pk" in _build/default/pk
 -> required by _build/default/META.mirage-crypto-pk
 -> required by _build/install/default/lib/mirage-crypto-pk/META
 -> required by _build/default/mirage-crypto-pk.install
 -> required by alias install
```
@hannesm
Copy link
Member Author

hannesm commented Jun 24, 2024

This is fine to merge, and should unblock #26094

CI errors can be fixed in different PRs, this is only affecting old mirage-crypto-pk releases.

@mseri mseri merged commit b615146 into ocaml:master Jun 24, 2024
1 of 3 checks passed
@mseri
Copy link
Member

mseri commented Jun 24, 2024

Thanks

@hannesm hannesm deleted the mirage-crypto-pk-bound-on-eqaf branch June 24, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants