Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new file: packages/orf/orf.1.0.1/opam #22843

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Conversation

UnixJunkie
Copy link
Contributor

compiles w/ ocaml-5 and many other versions probably

compiles w/ ocaml-5 and many other versions probably
@kit-ty-kate
Copy link
Member

The 1.0.1 tag/archive doesn’t exist

@UnixJunkie
Copy link
Contributor Author

Sorry, now it does; forgot to push the tags.

@raphael-proust
Copy link
Collaborator

There are lower bound issues re: Seq:


#=== ERROR while compiling orf.1.0.1 ==========================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.11.2 | pinned(https://github.com/UnixJunkie/orf/archive/refs/tags/v1.0.1.tar.gz)
# path                 ~/.opam/4.11/.opam-switch/build/orf.1.0.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p orf -j 31
# exit-code            1
# env-file             ~/.opam/log/orf-7-009d12.env
# output-file          ~/.opam/log/orf-7-009d12.out
### output ###
# File "/home/opam/.opam/4.11/lib/bst/bst.dune", line 1, characters 0-0:
# Warning: .dune files are ignored since 2.0. Reinstall the library with dune
# >= 2.0 to get rid of this warning and enable support for the subsystem this
# library provides.
#       ocamlc src/.orf.objs/byte/orf__RFC.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.11/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.orf.objs/byte -I src/.orf.objs/public_cmi -I /home/opam/.opam/4.11/lib/batteries -I /home/opam/.opam/4.11/lib/bytes -I /home/opam/.opam/4.11/lib/cpm -I /home/opam/.opam/4.11/lib/cpu -I /home/opam/.opam/4.11/lib/dolog -I /home/opam/.opam/4.11/lib/line_oriented -I /home/opam/.opam/4.11/lib/num -I /home/opam/.opam/4.11/lib/ocaml/threads -I /home/opam/.opam/4.11/lib/parany -intf-suffix .ml -no-alias-deps -open Orf -o src/.orf.objs/byte/orf__RFC.cmo -c -impl src/RFC.ml)
# File "src/RFC.ml", line 214, characters 24-37:
# 214 |                      ) (IntSet.to_seq values)
#                               ^^^^^^^^^^^^^
# Error: Unbound value IntSet.to_seq
#     ocamlopt src/.orf.objs/native/orf__RFC.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.11/bin/ocamlopt.opt -w -40 -g -I src/.orf.objs/byte -I src/.orf.objs/native -I src/.orf.objs/public_cmi -I /home/opam/.opam/4.11/lib/batteries -I /home/opam/.opam/4.11/lib/bytes -I /home/opam/.opam/4.11/lib/cpm -I /home/opam/.opam/4.11/lib/cpu -I /home/opam/.opam/4.11/lib/dolog -I /home/opam/.opam/4.11/lib/line_oriented -I /home/opam/.opam/4.11/lib/num -I /home/opam/.opam/4.11/lib/ocaml/threads -I /home/opam/.opam/4.11/lib/parany -intf-suffix .ml -no-alias-deps -open Orf -o src/.orf.objs/native/orf__RFC.cmx -c -impl src/RFC.ml)
# File "src/RFC.ml", line 214, characters 24-37:
# 214 |                      ) (IntSet.to_seq values)
#                               ^^^^^^^^^^^^^
# Error: Unbound value IntSet.to_seq

You probably either need to depend on OCaml >= 4.12, or add a dependency to a stdlib compatibility package.


There are also some lower-bounds issues with a Cmp.Utls module


#=== ERROR while compiling orf.1.0.1 ==========================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.1 | pinned(https://github.com/UnixJunkie/orf/archive/refs/tags/v1.0.1.tar.gz)
# path                 ~/.opam/4.14/.opam-switch/build/orf.1.0.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p orf -j 31
# exit-code            1
# env-file             ~/.opam/log/orf-7-2b7e59.env
# output-file          ~/.opam/log/orf-7-2b7e59.out
### output ###
# File "/home/opam/.opam/4.14/lib/bst/bst.dune", line 1, characters 0-0:
# Warning: .dune files are ignored since 2.0. Reinstall the library with dune
# >= 2.0 to get rid of this warning and enable support for the subsystem this
# library provides.
#       ocamlc src/.model.eobjs/byte/dune__exe__Model.{cmi,cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.model.eobjs/byte -I /home/opam/.opam/4.14/lib/batteries -I /home/opam/.opam/4.14/lib/bst -I /home/opam/.opam/4.14/lib/bytes -I /home/opam/.opam/4.14/lib/cpm -I /home/opam/.opam/4.14/lib/cpu -I /home/opam/.opam/4.14/lib/dolog -I /home/opam/.opam/4.14/lib/line_oriented -I /home/opam/.opam/4.14/lib/minicli -I /home/opam/.opam/4.14/lib/molenc -I /home/opam/.opam/4.14/lib/num -I /home/opam/.opam/4.14/lib/ocaml/threads -I /home/opam/.opam/4.14/lib/parany -I src/.orf.objs/public_cmi -no-alias-deps -open Dune__exe -o src/.model.eobjs/byte/dune__exe__Model.cmo -c -impl src/model.ml)
# File "src/model.ml", line 31, characters 14-31:
# 31 |   let folds = Cpm.Utls.cv_folds nfolds training_set in
#                    ^^^^^^^^^^^^^^^^^
# Error: Unbound module Cpm.Utls

I don't know where that comes from. You probably just need to add some lower bound constraint to whatever package pulls this in.

@avsm
Copy link
Member

avsm commented Jun 7, 2023

@UnixJunkie would you mind taking a look at the issues above please, or closing this?

@haochenx
Copy link
Collaborator

Hi @UnixJunkie do you mind to revisit this PR?

If you want to go with the approach to add lower bounds, https://github.com/ocaml/opam-repository/wiki/Lower-bound-check---DYI might be useful.

packages/orf/orf.1.0.1/opam Outdated Show resolved Hide resolved
packages/orf/orf.1.0.1/opam Outdated Show resolved Hide resolved
@samoht
Copy link
Member

samoht commented Apr 2, 2024

More lower bounds issues -- @UnixJunkie would you mind looking at those?

-> installed bst.3.0.0
-> installed conf-python-3.1.0.0
-> installed dune.2.8.0
-> installed ocamlbuild.0.14.0
-> installed ocamlfind.1.8.1
-> installed dolog.4.0.0
-> installed minicli.5.0.2
-> installed cpu.2.0.0
-> installed num.1.0
-> installed parany.11.0.2
-> installed parmap.1.0-rc11
-> installed batteries.3.3.0
-> installed line_oriented.1.0.0
-> installed cpm.11.0.0
-> installed molenc.5.0.0
[ERROR] The compilation of orf.1.0.1 failed at "dune build -p orf -j 255".

#=== ERROR while compiling orf.1.0.1 ==========================================#
# context              2.2.0~beta2~dev | linux/x86_64 | ocaml-base-compiler.4.12.1 | pinned(https://github.com/UnixJunkie/orf/archive/refs/tags/v1.0.1.tar.gz)
# path                 ~/.opam/4.12/.opam-switch/build/orf.1.0.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p orf -j 255
# exit-code            1
# env-file             ~/.opam/log/orf-7-bc5fe1.env
# output-file          ~/.opam/log/orf-7-bc5fe1.out
### output ###
# File "/home/opam/.opam/4.12/lib/bst/bst.dune", line 1, characters 0-0:
# Warning: .dune files are ignored since 2.0. Reinstall the library with dune
# >= 2.0 to get rid of this warning and enable support for the subsystem this
# library provides.
#       ocamlc src/.model.eobjs/byte/dune__exe__Model.{cmi,cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.model.eobjs/byte -I /home/opam/.opam/4.12/lib/batteries -I /home/opam/.opam/4.12/lib/bst -I /home/opam/.opam/4.12/lib/bytes -I /home/opam/.opam/4.12/lib/cpm -I /home/opam/.opam/4.12/lib/cpu -I /home/opam/.opam/4.12/lib/dolog -I /home/opam/.opam/4.12/lib/line_oriented -I /home/opam/.opam/4.12/lib/minicli -I /home/opam/.opam/4.12/lib/molenc -I /home/opam/.opam/4.12/lib/num -I /home/opam/.opam/4.12/lib/ocaml/threads -I /home/opam/.opam/4.12/lib/parany -I src/.orf.objs/native -I src/.orf.objs/public_cmi -no-alias-deps -open Dune__exe -o src/.model.eobjs/byte/dune__exe__Model.cmo -c -impl src/model.ml)
# File "src/model.ml", line 34, characters 26-39:
# 34 |        let actual = L.map Mol.get_value test in
#                                ^^^^^^^^^^^^^
# Error: Unbound value Mol.get_value
# Hint: Did you mean get_name?

Co-authored-by: Shon Feder <shon.feder@gmail.com>
@UnixJunkie
Copy link
Contributor Author

@shonfeder ok, let's try

@shonfeder
Copy link
Collaborator

That took care of the bounds checks!

We are also seeing a failure on windows https://github.com/ocaml/opam-repository/actions/runs/9589562081/job/26443537300

#=== ERROR while compiling conf-autoconf.0.2 ==================================#
"autoconf": command not found.


<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - fetch batteries     3.8.0
| - fetch cmdliner      1.3.0
| - fetch conf-python-3 9.0.0
| - build conf-autoconf 0.2
+- 
- No changes have been performed
# Run (& opam env) -split '\r?\n' | ForEach-Object { Invoke-Expression $_ } to update the current shell environment
orf.1.0.1 failed to build.

But that looks to be an issue with conf-autoconf.

The last thing here looks to be checksum, which should be updated to accord with the new policy:

2024-06-20 00:15.45: Error in orf.1.0.1: Weak checksum algorithm(s) provided. Please use SHA-256 or SHA-512. Details: opam field url contains only MD5 as checksum for https://github.com/UnixJunkie/orf/archive/refs/tags/v1.0.1.tar.gz

Once that is done this should be good to go. Thanks for your patience in getting the package configured, and for taking the time to share this :)

use a sha256 sum instead of md5
@UnixJunkie
Copy link
Contributor Author

this is now using a sha256 checksum instead of md5

@shonfeder
Copy link
Collaborator

Thank you!

@shonfeder
Copy link
Collaborator

The windows CI failure should be addressed by https://github.com/ocaml/opam-repository/pull/26140/files (iiuc)

@raphael-proust raphael-proust merged commit 55462e8 into ocaml:master Jul 3, 2024
2 of 3 checks passed
@raphael-proust
Copy link
Collaborator

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants