Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also install signatures.{cmi,cmti} #227

Merged
merged 2 commits into from
Mar 6, 2017
Merged

also install signatures.{cmi,cmti} #227

merged 2 commits into from
Mar 6, 2017

Conversation

gasche
Copy link
Member

@gasche gasche commented Mar 5, 2017

Hopefully fixes #217.

@gasche gasche mentioned this pull request Mar 5, 2017
Open
@dbuenzli dbuenzli merged commit 47091d4 into ocaml:master Mar 6, 2017
@gasche
Copy link
Member Author

gasche commented Mar 6, 2017

In fact I was a bit too optimistic about the usability of those languages. OCaml pull-requests (that pull from ocamlbuild master) are now failing with:

cp META src/signatures.{mli,cmi,cmti} /home/travis/local/lib/ocamlbuild
cp: cannot stat `src/signatures.{mli,cmi,cmti}': No such file or directory
make[1]: *** [install-lib-basics] Error 1

Oh well. Will fix.

@whitequark
Copy link
Member

@gasche How did this happen?

@dbuenzli
Copy link
Collaborator

dbuenzli commented Mar 6, 2017

Mmmh sorry about the merge then. It's strange the CI was saying yes. Is due to a lack bin_annot ?

@gasche
Copy link
Member Author

gasche commented Mar 6, 2017

I'm just as confused (no need to apologize!); -bin-annot is passed correctly (see the full failing logs), I wonder if this is just a case of the foo.{bar,baz} pattern not being expanded -- but I don't understand why that would be, might this be a bashism that some other shells don't support? I certainly cannot reproduce any install/uninstall issue on my machine.

gasche added a commit to gasche/ocamlbuild that referenced this pull request Mar 6, 2017
@gasche
Makefile: ci golf the install commands for signatures.{mli,cmi,cmti}
be7e542 
The OCaml CI seems to be failing with errors related to the
signatures.{mli,cmi,cmti} (un)install rules introduced in
PR ocaml#227 ( 1c83750 ):

  https://s3.amazonaws.com/archive.travis-ci.org/jobs/208163203/log.txt

```
cp META src/signatures.{mli,cmi,cmti} /home/travis/local/lib/ocamlbuild
cp: cannot stat `src/signatures.{mli,cmi,cmti}': No such file or directory
make[1]: *** [install-lib-basics] Error 1
```

I don't really understand what the problem is; to me it looks like the
`.{mli,cmi,cmti}` pattern is not recognized (by this seems to be
a genuine `bash` running?!), so this commit uses separate files
instead. Hopefully, even if the cause of the issue is something else
(for example one of these files may be missing for some reason and the
error message is just bad), the split in separate filenames may help
diagnose it.
@dbuenzli
Copy link
Collaborator

dbuenzli commented Mar 6, 2017

I wonder if this is just a case of the foo.{bar,baz} pattern not being expanded -- but I don't understand why that would be, might this be a bashism

Actually when I saw it I wanted to comment that it is a bashism but then thaught that this might be supported by the make language. So yes, it is a bashism.

@gasche gasche mentioned this pull request Mar 6, 2017
Merged
gasche added a commit to gasche/ocamlbuild that referenced this pull request Mar 6, 2017
@gasche
Makefile: ci golf the install commands for signatures.{mli,cmi,cmti}
5e1ce37 
The OCaml CI seems to be failing with errors related to the
signatures.{mli,cmi,cmti} (un)install rules introduced in
PR ocaml#227 ( 1c83750 ):

  https://s3.amazonaws.com/archive.travis-ci.org/jobs/208163203/log.txt

```
cp META src/signatures.{mli,cmi,cmti} /home/travis/local/lib/ocamlbuild
cp: cannot stat `src/signatures.{mli,cmi,cmti}': No such file or directory
make[1]: *** [install-lib-basics] Error 1
```

I don't really understand what the problem is; to me it looks like the
`.{mli,cmi,cmti}` pattern is not recognized (but this seems to be
a genuine `bash` running?!), so this commit uses separate files
instead. Hopefully, even if the cause of the issue is something else
(for example one of these files may be missing for some reason and the
error message is just bad), the split in separate filenames may help
diagnose it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbuenzli dbuenzli dbuenzli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPR#5243: Improve the API documentation
3 participants
@gasche @whitequark @dbuenzli