Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook for invert a matrix using owl library #2632

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

RCHG
Copy link

@RCHG RCHG commented Aug 4, 2024

Hello. I have created a cookbook recipe for "invert a matrix" using the Owl library. My 1st cookbook, so happy to introduce changes/improvements where needed.

@christinerose
Copy link
Collaborator

Hi @RCHG! Thanks for requesting my review. Forgive the delay, as I was on holiday for the past two weeks. Just mostly minor grammar/formatting things. I think I caught a missing word close to zero rather than close zero; however, if I'm mistaken, let's work together to determine what you meant there.

@RCHG
Copy link
Author

RCHG commented Aug 25, 2024

Thanks for the update. You are right: the statement should be "close to zero". In pure math they have to be zero but, I guess, in computer algorithms we can only guarantee a tiny float number. Everything seems to be fine now.

packages: [owl]
---

(* Creates an Owl `float` matrix using random numbers drawn from a uniform distribution with `Owl.Mat.uniform`. It is very likely that it will be invertible but we ensure it by checking that the determinat is not zero with `Owl.Linalg.D.dat`. The dimensions of the matrix are defined by `m`. *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(* Creates an Owl `float` matrix using random numbers drawn from a uniform distribution with `Owl.Mat.uniform`. It is very likely that it will be invertible but we ensure it by checking that the determinat is not zero with `Owl.Linalg.D.dat`. The dimensions of the matrix are defined by `m`. *)
(* Creates an Owl `float` matrix using random numbers drawn from a uniform distribution with `Owl.Mat.uniform`. It is very likely that it will be invertible, but we ensure it by checking that the determinat is not zero with `Owl.Linalg.D.dat`. The dimensions of the matrix are defined by `m`. *)

Should the word be "determinant" or is "determinat" correct?

Copy link
Collaborator

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar correction and a possible typo

@RCHG
Copy link
Author

RCHG commented Aug 31, 2024

Minor grammar correction and a possible typo

Thank you, yes it should be determinant. Also it should be Owl.Linalg.D.det instead of Owl.Linalg.D.dat

Adding suggested changes by christinerose
@RCHG
Copy link
Author

RCHG commented Oct 1, 2024

This seems to be finished and ready, but their integration seems frozen since Aug. Do I need to do something more? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants