Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoload): Set caml-mode to autoload #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcs090218
Copy link
Contributor

Add autoload to caml-mode so it can be called without doing (require 'caml). Adjust auto-mode-alist so it can be load automatically when the extensions matches.

@nojb
Copy link
Contributor

nojb commented Aug 16, 2022

The changes look good. @Chris00 is there something that can be done to help merging this?

@bbatsov
Copy link

bbatsov commented Sep 28, 2022

Looks good to me as well, although I'd probably split this into two commits. You might also adjust the README, as it currently suggests setting up the file extension mappings manually.

@Chris00
Copy link
Member

Chris00 commented Sep 28, 2022

You might also adjust the README

Yes, please.

@monnier
Copy link
Contributor

monnier commented Oct 3, 2023

Hmm... I agree with the autoload cookie, of course )(and I just merged this part), but I'm not so sure about the auto-mode-alist change because I think it'll conflict with the one in Tuareg-mode.
AFAIK the "recommended" major mode is Tuareg-mode, but installing Tuareg also installs Caml-mode, so I'd rather not inflict this conflict on all the Tuareg users.
Maybe we could use major-mode-remap-alist to resolve the conflict, but that'll only be available in Emacs-30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants