Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Chrome version in docker tests #484

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

oblador
Copy link
Owner

@oblador oblador commented Oct 31, 2023

Previously the unit tests used latest which caused them to suddenly fail because Chrome is crashing. Long term we would probably want to investigate why latest version is crashing (if it's an issue with the docker image or with the GitHub Action environment).

try {
await execute(dockerPath, ['kill', dockerId]);
} catch (e) {
if (e.toString().indexOf('No such container') === -1) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the container crashes, failing to kill it obscured the real error.

@@ -43,7 +43,7 @@ const waitOnCDPAvailable = (host, port) =>

function createChromeDockerTarget({
baseUrl = 'http://localhost:6006',
chromeDockerImage = 'yukinying/chrome-headless-browser-stable',
chromeDockerImage = 'yukinying/chrome-headless-browser-stable:100.0.4896.127',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oblador oblador merged commit e50e799 into master Oct 31, 2023
4 checks passed
@oblador oblador deleted the lock-chrome-docker-version-test branch October 31, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants