-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unlimited-depth directly-optimal recursion. #83
Draft
obi1kenobi
wants to merge
32
commits into
main
Choose a base branch
from
infinite_recursion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlimited-depth recursion makes adapters even more likely to accidentally trigger the same re-entrancy bug as in #205. The best way I can see is making a change to the |
obi1kenobi
added
S-experimental
Status: ongoing experiment that does not require reviewing and won't be merged in its current state.
C-enhancement
Category: raise the bar on expectations
labels
Jun 30, 2023
obi1kenobi
force-pushed
the
main
branch
3 times, most recently
from
November 17, 2023 19:59
15f64a4
to
64ebfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: raise the bar on expectations
S-experimental
Status: ongoing experiment that does not require reviewing and won't be merged in its current state.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new directly-optimal recursion execution algorithm that can support unlimited-depth recursion, developed in collaboration with @bojanserafimov as part of the HYTRADBOI'22 Jam: https://www.hytradboi.com/jam
Traces show that the new implementation produces the first result in less than half as many steps on even the shallowest of recursion situations. The more steps previously involved in getting the first result from the recursion, the more significant the improvement will be.
After this merges, we'll still need to update the front-end to make the
@recurse
depth parameter nullable and plumb that change throughout Trustfall to enable unlimited-depth recursion.