Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor test suite for trustfall_wasm [WIP] #555

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

devanbenz
Copy link
Contributor

  • Currently a WIP
  • Moving inline javascript out in to its own separate modules
  • Attempting to fix node tests --stupid ESM/CommonJS >:(--
  • Adding more test coverage
  • Migrating JS --> TS

@devanbenz
Copy link
Contributor Author

LOL @ // Currently failing because of the "export" keyword in iterify(). comment in the node test suite 😆 gotta love javascript and its inability to have the same package management system in both node and web

@obi1kenobi
Copy link
Owner

LOL @ // Currently failing because of the "export" keyword in iterify(). comment in the node test suite 😆 gotta love javascript and its inability to have the same package management system in both node and web

Yeah, it's been really frustrating to be honest. Real Python 2 vs Python 3 vibes.

@devanbenz devanbenz changed the title feat: Refactor test suite for trustfall_wasm feat: Refactor test suite for trustfall_wasm [WIP] Feb 14, 2024
@devanbenz
Copy link
Contributor Author

Will be coming back to this PR over the weekend! I was out of town last week/over the weekend :D

@obi1kenobi
Copy link
Owner

Hey! Just checking in to see if you're still thinking about working on this, or if you got blocked on something I could help with.

No worries if you had other stuff come up, or if for whatever reason you can't work on it anymore. Stuff happens, and I appreciate your help here!

@devanbenz
Copy link
Contributor Author

Hey! Yeah I've been really busy with work lately 🙃 If someone else is interested in taking this on feel free to reassign. I'm hoping to have some more free time after I finish up a project that's "crunch time" at work.

@obi1kenobi
Copy link
Owner

No rush! If you're still interested in this, it's all yours. Good luck with the crunch time project!

@devanbenz
Copy link
Contributor Author

No rush! If you're still interested in this, it's all yours. Good luck with the crunch time project!

Definitely still interested - would love to contribute more as I start to have more free time in the next coming weeks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants