Escape stubgen names #406
Merged
Escape stubgen names #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u9g
commented
Jul 25, 2023
..._stubgen/test_data/expected_outputs/use_reserved_rust_names_in_schema/adapter/schema.graphql
Show resolved
Hide resolved
obi1kenobi
reviewed
Jul 25, 2023
..._stubgen/test_data/expected_outputs/use_reserved_rust_names_in_schema/adapter/schema.graphql
Show resolved
Hide resolved
obi1kenobi
force-pushed
the
escape-stubgen-names
branch
from
485d7b4
to
4356eea
Compare
obi1kenobi
reviewed
Jul 26, 2023
trustfall_stubgen/src/root.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn ensure_no_edge_name_keyword_conflicts( |
There was a problem hiding this comment.
This function can probably use a better name, more in line with the panic message below
..._stubgen/test_data/expected_outputs/use_reserved_rust_names_in_schema/adapter/schema.graphql
Show resolved
Hide resolved
obi1kenobi
reviewed
Jul 27, 2023
Comment on lines
3
to
9
| pub enum Vertex { | ||
| Type(()), | ||
| Type2(()), | ||
| unsafe2(()), | ||
|
|
||
| use_(()), | ||
|
|
||
| use2(()), | ||
| } |
There was a problem hiding this comment.
This will cause a lint by default because variant names should be capitalized. Let's capitalize them.
Also, probably add another test that has both upper and lower case of the same keyword at the same time, to make sure we generate a good error there.
There was a problem hiding this comment.
especially this comment: aae96cf#diff-78e3b031bbc47a6bd07fe535e64778cc8f9030a9b983f9ebe8ef4d16ad61f581R432-R433
obi1kenobi
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #392.