Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zstd compression #695

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abitofevrything
Copy link
Member

Description

Add support for zstd-stream transport compression.

Drafted for now so we can determine whether adding a dependency on another package for this is worth it, especially as it is an unofficial third-party package based on FFI, and not portable.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the enhancement New feature or request label Sep 6, 2024
@abitofevrything abitofevrything added this to the 6.4.0 milestone Sep 6, 2024
@abitofevrything abitofevrything self-assigned this Sep 6, 2024
@abitofevrything abitofevrything removed this from the 6.4.0 milestone Sep 6, 2024
@l7ssha l7ssha added this to the 6.4.0 milestone Sep 13, 2024
@l7ssha l7ssha modified the milestones: 6.4.0, 6.5.0 Oct 4, 2024
Comment on lines +470 to +471
// See https://github.com/instantiations/es_compression/issues/52 for why the isNotEmpty check is needed.
Stream<dynamic> decompressZStdTransport(Stream<List<int>> raw) => raw.transform(zstd.decoder).where((message) => message.isNotEmpty);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is isNotEmpty still needed? instantiations/es_compression#52 (comment)

@abitofevrything abitofevrything removed this from the 6.5.0 milestone Oct 6, 2024
@l7ssha l7ssha modified the milestone: 6.5.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants