Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Effect/Itemproperty extending #1056

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Morderon
Copy link
Contributor

The +5 (or whatever) remains in effect and the material property acts as an or.

% based critical/sneak attack immunity.

Plugin choice: Placed in effect as % based critical/sneak attack immunity uses an exclusive hook (though not yet approved).

Damage reduction can go anywhere.

Known issues:
When multiple linked damage reduction is restored incorrectly.
% based immunities only work if the item property hook is active.

To do: Documentation

Things I don't like: forced reservation of an effect ParamInteger, but it at least provides specific-effect material based DR which won't get lost when linking multiple material based damage reductions.

UnpackEvent - now displays ID, useful to tell linked applied effects.

New functions:

GetTrueEffect(Count)

RemoveEffectById

SetEffectImmunityBypass

ReplaceEffectByElement
The +5 (or whatever) remains in effect and the material property acts as an or.

% based critical/sneak attack immunity.


Known issues:
When multiple linked damage reduction is restored incorrectly.
% based immunities only work if the item property hook is active.

To do: Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant