perf: Make ViewModelBase's internal errors dictionary lazy initialized #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
What is the current behavior?
_errors
dictionary for theINotifyDataErrorInfo
aspect ofViewModelBase
is always instantiated, even if theINotifyDataErrorInfo
features aren't used for a ViewModel._errors
dictionary is aConcurrentDictionary
.What is the new behavior?
_errors
field is now aDictionary
. We weren't using any features specific toConcurrentDictionary
._errors
field is now lazy-initialized. It staysnull
as long a we don't callSetErrors
.Impact on version
build
folder was changed..github
folder was changed.Checklist
Please check that your PR fulfills the following requirements:
Other information