Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DynamicProperties no longer throw ObjectDisposedExceptions #93

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jeanplevesque
Copy link
Member

GitHub Issue:
Fixes #90

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

  • Setting the Value property of a DynamicProperty while it is disposed throws an ObjectDisposedException.

What is the new behavior?

  • Setting the Value property of a DynamicProperty while it is disposed logs a debug message.
  • All overloads using a throwOnDisposed parameters are marked as obsolete.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

…n we set their Value while they're disposed.
@jeanplevesque jeanplevesque requested a review from a team December 15, 2023 16:59
@jeanplevesque jeanplevesque merged commit 3a43c23 into main Dec 15, 2023
4 checks passed
@jeanplevesque jeanplevesque deleted the dev/jpl/dont-throw branch December 15, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeactivatableDynamicPropertyFromObservable, throwOnDisposed and race conditions
3 participants