Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implemented workaround for Uno.Toolkit.UI error #83

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ryanwin98
Copy link
Contributor

@ryanwin98 ryanwin98 commented Oct 31, 2023

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe: workaround

What is the current behavior?

Currently when upgrading a project to Uno 5+ the following message is displayed when using this package:
image

What is the new behavior?

Workaround implemented avoids including Uno.Toolkit.UI XBFs in the PRI file

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

Currently a WIP as the investigation continues to locate all the packages that cause this exception to be thrown

@ryanwin98 ryanwin98 changed the title feat: implemented workaround for Uno.Toolkit.UI error chore: implemented workaround for Uno.Toolkit.UI error Nov 2, 2023
@ryanwin98 ryanwin98 force-pushed the dev/rywi/toolkit-err-wrkaround branch from ef998f8 to eedebaf Compare November 2, 2023 14:06
@ryanwin98 ryanwin98 marked this pull request as ready for review November 2, 2023 14:07
@ryanwin98 ryanwin98 requested a review from a team November 2, 2023 14:07
@ryanwin98 ryanwin98 changed the title chore: implemented workaround for Uno.Toolkit.UI error fix: implemented workaround for Uno.Toolkit.UI error Nov 2, 2023
@ryanwin98 ryanwin98 force-pushed the dev/rywi/toolkit-err-wrkaround branch from eedebaf to 841a958 Compare November 2, 2023 14:23
@ryanwin98 ryanwin98 marked this pull request as draft November 2, 2023 14:23
@ryanwin98 ryanwin98 changed the base branch from main to feature/Uno5Update November 2, 2023 18:45
@ryanwin98 ryanwin98 marked this pull request as ready for review November 2, 2023 18:45
@ryanwin98 ryanwin98 merged commit b6df421 into feature/Uno5Update Nov 2, 2023
4 checks passed
@ryanwin98 ryanwin98 deleted the dev/rywi/toolkit-err-wrkaround branch November 2, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants