Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't throw ObjectDisposedException when calling RaisePropertyCh… #101

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jeanplevesque
Copy link
Member

…anged on a disposed VM to align with the RaisePropertyChangedInner behavior.

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

An ObjectDisposedException is thrown when invoking RaisePropertyChanged on a disposed ViewModelBase.
No ObjectDisposedException is thrown when invoking RaisePropertyChangedInner on a disposed ViewModelBase.

What is the new behavior?

No ObjectDisposedException is thrown when invoking any of RaisePropertyChanged or RaisePropertyChangedInner on a disposed ViewModelBase.
Note however that a debug-level log message is triggered in both cases.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.
    • Only code in the Benchmarks project was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

…anged on a disposed VM to align with the RaisePropertyChangedInner behavior.
@jeanplevesque jeanplevesque requested a review from a team June 18, 2024 18:11
@jeanplevesque jeanplevesque merged commit f49027a into main Jun 18, 2024
4 checks passed
@jeanplevesque jeanplevesque deleted the dev/jpl/fix branch June 18, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants