Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an overload of GetFromObservable that uses a func #100

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jeanplevesque
Copy link
Member

@jeanplevesque jeanplevesque commented Feb 9, 2024

Fixes #99

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

  • Add an overload of GetFromObservable that uses a Func<IObservable<T>> to avoid potential wasteful materializations of observable chains.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.
    • Only code in the Benchmarks project was changed.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated Unit / Integration tests for the changes have been added/updated.
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).
  • Your conventional commits are aligned with the Impact on version section.

Other information

…wasteful materializations of observable chains.
@jeanplevesque jeanplevesque requested a review from a team February 9, 2024 16:42
@jeanplevesque jeanplevesque merged commit 7b2eb5b into main Feb 9, 2024
4 checks passed
@jeanplevesque jeanplevesque deleted the dev/jpl/func-get-from-observable branch February 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GetFromObservable<T> overload with Func<IObservable<T>>
4 participants