Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog support by default #45

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

jmdaweb
Copy link
Contributor

@jmdaweb jmdaweb commented Oct 6, 2024

Include a changelog file which will be part of the release body when GitHub workflow is triggered. Add-on SHA256 sum will always be printed at the end of the file.
Currently, most add-on developers don't explain what has changed between releases. A few of them edit the release to add a description, but it's too late to receive that description as part of the release notification. Others prefer automatic release notes, which point to a comparison page with a list of commits.
This pr adds the ability to summarise add-on changes in a file using Markdown, commit that file and have a changelog by default as part of the release body, saving extra time for developers.

…GitHub workflow is triggered. Add-on SHA256 sum will always be printed at the end of the file
Copy link
Contributor

@josephsl josephsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we should document GitHub workflows in the add-on template readme if not done so already.

@josephsl
Copy link
Contributor

By the way, please resolve conflicts so merging can e done smoothly.

@jmdaweb
Copy link
Contributor Author

jmdaweb commented Oct 19, 2024

@josephsl ready to merge. There are also other prs from Dependabot awaiting for review. Regarding documentation, you write much better than me, but if you don't have time enough, I may update it in another pull request.

@josephsl josephsl merged commit 185fe41 into nvdaaddons:master Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants