fix(SelectMenu): use by
prop to compare objects for selected values
#2228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
fixes #2028
β Type of change
π Description
This PR fixes a bug introduced in #1349, where the
by
prop was not being consiederd when computing the selected values.It also adds the possibility to combine the
by
prop with thevalue-attribute
prop to compare nested objects like in the following example:π Checklist