Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notes with scoop x64 #670

Closed
wants to merge 4 commits into from
Closed

add notes with scoop x64 #670

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2024

No description provided.

x64 support json
@ghost ghost changed the title add scoop with notes.json add scoop May 8, 2024
@ghost ghost mentioned this pull request May 8, 2024
@ghost ghost changed the title add scoop add scoop x64 May 8, 2024
@ghost ghost changed the title add scoop x64 add notes with scoop x64 May 8, 2024
@ghost ghost marked this pull request as draft May 9, 2024 17:21
@ghost ghost closed this May 9, 2024
@ghost ghost reopened this May 10, 2024
@ghost ghost closed this May 21, 2024
@ghost ghost reopened this May 22, 2024
@guihkx
Copy link
Collaborator

guihkx commented May 22, 2024

Hey, thanks for working on this! :)

I haven't tested this properly yet, as I don't usually review draft pull requests, because they're technically not ready...

But anyway, you should probably update the notes.json file to use the Qt 6 build instead of the Qt 5 one, since the latter doesn't have the Kanban feature.

@guihkx
Copy link
Collaborator

guihkx commented May 22, 2024

I'm not familiar with how Scoop works, but after we install Notes using it, how do we open it?

I assume Notes can only be launched through the command line, and it won't be available in Windows' start menu... Or am I mistaken?

@guihkx
Copy link
Collaborator

guihkx commented May 22, 2024

Thanks for clarifying things!

In my opinion, since Notes is obviously a graphical-only program, having a shortcut in the start menu to open it is a must. If this is indeed doable with Scoop, I'd prefer having that before we could merge it.

I was wondering where I should store notes.json, or if I should create notesx86.json

I'm not sure what other contributors think, but in my opinion, having a single notes.json file only for the x64 Qt 6 build is preferable.

We pretty much only offer the x86 Qt 5 build because, apparently, some of our users are still on Windows 7, where Qt 6 isn't officially supported.

@guihkx
Copy link
Collaborator

guihkx commented May 22, 2024

I was asking if I should submit the pull request to the scoop community or here

I definitely think it would make more sense to submit to the Scoop community instead.

Based on a quick look I took at how Scoop works, they seem to have their own official repositories, so installing Notes from one of those would be much better, IMO.

However, if they have a way to "import" the Scoop file from third-party repositories (i.e., from here into their own repositories), I think it would be even better.

Just so we can "control" the release process better, directly from here.

@ghost ghost closed this May 25, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants