vi mode: Introduce alternate escape sequence for insert mode

[benvansleen]

This PR introduces a new argument to the Vi::new constructor: the alternate_esc_seq. When set to (KeyCode::Null, KeyCode::Null), this does nothing.

alternate_esc_seq can be set to something like (KeyCode::Char('j'), KeyCode::Char('k')) -- allowing the user to press "jk" (without modifiers) to move from Vi insert mode to Vi normal mode.

I wrote this because I would love to be able to use "jj" to enter normal mode in Nu (like I do for all other similar vi-modes).

(I am very new to Rust, Nu, and Reedline; if something is non-idiomatic, please tell me!)

[benvansleen]

Addressing: #499

[codecov]

Codecov Report

Merging #670 (dfa469b) into main (93af55c) will decrease coverage by 0.07%.
The diff coverage is 42.85%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   49.19%   49.12%   -0.07%     
==========================================
  Files          46       46              
  Lines        7930     7959      +29     
==========================================
+ Hits         3901     3910       +9     
- Misses       4029     4049      +20     

Files	Coverage Δ
src/edit_mode/vi/mod.rs	61.90% <42.85%> (-4.20%)	⬇️

... and 3 files with indirect coverage changes

[kuchta]

Actually all other major vi modes (vim, bash, zsh) uses Meta (Alt) + whatever for entering normal mode. If you get used to it, it's indispensable, but reedline is the only one that doesn't support that...

[tamlok]

Can we use ctrl+[ to exit insert mode?

[benvansleen]

@tamlok
Yes, the keycode C-[ is equivalent to ESC.

[fdncred]

Is this exposed so that one can define what they like in the nushell config.nu keybindings section?

[benvansleen]

@fdncred

I believe the config.nu configuration is defined within the nushell crate. In reedline, this configuration is exposed by the Vi constructor.

If this PR is approved, I will write an accompanying nushell PR.

[fdncred]

I believe the config.nu configuration is defined within the nushell crate.

yes, of course. What I'm saying is will there be some way to define it in the keybinings section like this below but changed somehow to allow for other key combinations to be used for alternate_esc_seq instead of just j/k.

  {
    name: abbr
    modifier: control
    keycode: space
    mode: [emacs, vi_normal, vi_insert]
    event: [
    { send: menu name: alias_menu }
    { edit: insertchar, value: ' '}
    ]
  }

[benvansleen]

Ah, I see what you mean. Currently, on the reedline side of things, the keys composing the sequence are configured by the (new) 3rd argument to Vi::new:

Vi::new(insert_mode_keybinds, normal_mode_keybinds, (KeyCode::x, KeyCode::y))

This means the user can press "x" then "y" to exit insert-mode. (Passing (KeyCode::Null, KeyCode::Null) instead recovers the current behavior where only ESC exits insert-mode.)

I was thinking of implementing the nushell PR such that config.nu would look something like this:

...
bracketed_paste: true # enable bracketed paste, currently useless on windows
edit_mode: vi # emacs, vi
vi_alternate_esc_seq: { first: x, second: y }
shell_integration: true # enables terminal shell integration. Off by default, as some terminals have issues with this.
...

Achieving this with the existing keybindings section would require implementing something akin to emacs key-chords (since you press one key, release, then press the next). That would be a much, much wider-reaching change.

[eggcaker]

any news?