Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto IP tracking #1142

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Fix auto IP tracking #1142

merged 1 commit into from
Aug 27, 2023

Conversation

shaxxx
Copy link
Contributor

@shaxxx shaxxx commented Aug 1, 2023

When auto IP function assigns new IP to existing edge node, it's current IP address is not updated.
Which leads to duplicate IP's assigned when Pearson hash returns same value for two edge clients.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (6b8ba8a) 21.67% compared to head (be9c31a) 21.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1142      +/-   ##
==========================================
- Coverage   21.67%   21.66%   -0.01%     
==========================================
  Files          46       46              
  Lines        8993     8996       +3     
==========================================
  Hits         1949     1949              
- Misses       7044     7047       +3     
Files Changed Coverage Δ
src/sn_utils.c 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamishcoleman
Copy link
Collaborator

When you have finished your testing, mark this as ready for review and we will get it merged

@shaxxx
Copy link
Contributor Author

shaxxx commented Aug 4, 2023

Will do. So far it works fine, only change from previous version is there are no disconnected clients listed on the management port.
Before, if clients did not make clean shutdown it's info would be still visible with last seen time somewhere in the past.
Now, ali visible clients last seen time is within one minute. For me this is fantastic.
Let's wait until Monday.

@shaxxx shaxxx marked this pull request as ready for review August 7, 2023 09:35
@shaxxx
Copy link
Contributor Author

shaxxx commented Aug 7, 2023

All good, ready for merge.

@hamishcoleman hamishcoleman merged commit 7c10788 into ntop:dev Aug 27, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants