Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): not to cache entire workspace root #28552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Oct 22, 2024

Current Behavior

  • if directory is workspace root, when walking through the directory, it will include the directory root path, then will strip prefix, it will be empty string. it will return "*" as a found path.
  • When copying "*", it will run into a recursive loop because it will try to copy the walkspace root with node_modules into node_modules/.cache/nx

Expected Behavior

Related Issue(s)

Fixes #28393

@xiongemi xiongemi requested review from a team as code owners October 22, 2024 04:47
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Oct 22, 2024 4:47am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx cache may infinitely recurse
1 participant