feat: added SignatureMediaTypes to RemoteVerifyOptions #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 73.23% 73.27% +0.04%
==========================================
Files 23 23
Lines 1984 1987 +3
==========================================
+ Hits 1453 1456 +3
Misses 429 429
Partials 102 102
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
patrickzheng200
changed the title
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
force-pushed
the
signatureMediaType
branch
from
81b773e
to
d0a586a
Compare
…00/notation-go into signatureMediaType
patrickzheng200
force-pushed
the
signatureMediaType
branch
from
5495a82
to
35d9060
Compare
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
force-pushed
the
signatureMediaType
branch
from
2d1a856
to
e9545a7
Compare
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Dec 19, 2022
|
Have added couple of comments on #217, lets discuss in the issue about this feature. |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
…00/notation-go into signatureMediaType
|
Closed this PR as the issue requires further discussion in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SignatureMediaTypes to RemoteVerifyOptions.
The details regarding this PR is tracked in #217.
Signed-off-by: Patrick Zheng patrickzheng@microsoft.com