Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a new event "headerLines" to gain access to the raw headers #364

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

katlimruiz
Copy link
Contributor

@katlimruiz katlimruiz commented Apr 1, 2024

Why?

I need to gain access to the raw headers for human analysis.

Was there a workaround?

Yes, to reverse-engineer the headers map which is not ideal.

Was there other ways to implement it?

Yes, the other option was to emit headers with a new wrapper object with both headers and headerLines, however, that would break backward compatibility.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2024

CLA assistant check
All committers have signed the CLA.

@andris9 andris9 merged commit d33d7ec into nodemailer:master Apr 1, 2024
4 checks passed
@katlimruiz
Copy link
Contributor Author

@andris9 Thanks for the approval! I guess this will require a new release. Is there any plan to do that soon?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants