Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension-grants.rst with example #92

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Update extension-grants.rst with example #92

merged 5 commits into from
Mar 30, 2022

Conversation

FStefanni
Copy link
Contributor

@FStefanni FStefanni commented Nov 28, 2021 •
edited by jankapunkt
Loading

Hi,

just updated a doc example, which seems fine to me.
I have left classes on purpose, since it is a more modern JS syntax, and probably also this code base is moving to more modern JS.

Regards.

Edit by @jankapunkt: Fixed issue 89, point 5, original issue 530

@FStefanni FStefanni mentioned this pull request Nov 28, 2021
Closed
33 tasks
@jankapunkt jankapunkt changed the base branch from master to development November 29, 2021 07:59
@jankapunkt jankapunkt changed the title Fixed issue 89, point 5, original issue 530 Update extension-grants.rst with example Dec 14, 2021
@jankapunkt jankapunkt linked an issue Dec 14, 2021 that may be closed by this pull request
[meta] list of original project pr #89
Closed
33 tasks
@jankapunkt
Copy link
Member

Can someone else review this, I am not using the rst files

jorenvandeweyer
jorenvandeweyer previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@jorenvandeweyer jorenvandeweyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but can we merge it without the changes to CHANGELOG.md, package.json and package-lock.json?

@FStefanni
Copy link
Contributor Author

FStefanni commented Mar 15, 2022 •
edited
Loading

Hi,

reverted the changes on CHANGELOG.md, package.json and package-lock.json.

Regards

@jankapunkt
Copy link
Member

@Uzlopak @HappyZombies @jorenvandeweyer should we include this in 4.2.0 ?

Uzlopak
Uzlopak previously approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok so far.

docs/misc/extension-grants.rst Outdated Show resolved Hide resolved
@HappyZombies
Copy link
Member

Yes it's ok so far and I'll put it for 4.2.0

@FStefanni , please update the typo and we can merge it

@FStefanni @Uzlopak
Update docs/misc/extension-grants.rst
274a54d 
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
@FStefanni
Copy link
Contributor Author

Done :)

@jankapunkt jankapunkt changed the base branch from development to release-4.2.0 March 30, 2022 07:17
@jankapunkt jankapunkt merged commit 1269719 into node-oauth:release-4.2.0 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankapunkt jankapunkt jankapunkt approved these changes

@Uzlopak Uzlopak Uzlopak left review comments

@jorenvandeweyer jorenvandeweyer jorenvandeweyer left review comments

@HappyZombies HappyZombies Awaiting requested review from HappyZombies

@jwerre jwerre Awaiting requested review from jwerre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[meta] list of original project pr
5 participants
@FStefanni @jankapunkt @HappyZombies @Uzlopak @jorenvandeweyer