Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show texture map using parameterization #232

Closed

Conversation

MarkGillespie
Copy link
Contributor

This adds a new parameterization visualization style which uses polyscope's existing texture mapping utilities to texture surface meshes using to the given parameterization.

(There's also a small modification to gl_engine.cpp to provide line numbers for shaders which fail to compile, which makes it easier to debug them)

@nmwsharp
Copy link
Owner

Thanks for submitting this, and sorry for the super long delay. I overhauled an integrated this in #239, now merged!

The main tweaks vs. here were (a) make the texture quantities share most cost with scalar/color quantities and just take a parameterization as a reference, because you might want many color-maps associated with a single set of UVs, and (b) use the new ManagedBuffer texture features, which were recently merged.

Let me know if that other merged PR missed anything or gives you any trouble!

@nmwsharp nmwsharp closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants