Add full Unicode support #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gvolpe
approved these changes
Apr 15, 2024
`dconf dump` uses `g_variant_print`, which prints most Unicode characters verbatim. dconf2nix would read those and then use `show` to serialize the parsed strings. But `show` encodes Unicode characters as a decimal number preceded by a backslash, (e.g. `\129315`), which means nothing to Nix. We have previously implemented special handling of strings consisting of just a single emoji code point, to be able to import GNOME Characters history. But an emoji glyph can consist of multiple code points, which was not handled. Let’s revert the emoji hack and add systematic Unicode support in next commit. Reverts 8a33e7c Reverts 9b44d67
`dconf dump` uses `g_variant_print`, which prints most Unicode characters verbatim. dconf2nix would read those and then use `show` to serialize the parsed strings. But `show` encodes Unicode characters as a decimal number preceded by a backslash, (e.g. `\129315`), which means nothing to Nix. Let’s encode strings as UTF-8 when dumping them to Nix. Also fix the test data from e2b5065, they were copied as reported by `parserTraced` but the actual data was mostly Unicode with few escape sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dconf dumpusesg_variant_print, which prints most Unicode characters verbatim. dconf2nix would read those and then useshowto serialize the parsed strings. Butshowencodes Unicode characters as a decimal number preceded by a backslash, (e.g.\129315), which means nothing to Nix.Let’s encode strings as UTF-8 when dumping them to Nix.
Also fix the test data from e2b5065, they were copied as reported by
parserTracedbut the actual data was mostly Unicode with few escape sequences.