Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Fix style in update_authors.py #115

Merged
merged 1 commit into from
May 15, 2024

Conversation

jhlegarreta
Copy link
Collaborator

@jhlegarreta jhlegarreta commented May 10, 2024

Fix style in update_authors.py following commits nipreps/eddymotion@b09cbd1 and
nipreps/eddymotion@d8955fe

@jhlegarreta
Copy link
Collaborator Author

To be merged before #114 to remove the related errors in
https://github.com/nipreps/nireports/actions/runs/9039147636/job/24841504857?pr=114#step:4:277

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.68%. Comparing base (43dd874) to head (3faf24d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   58.34%   58.68%   +0.33%     
==========================================
  Files          22       22              
  Lines        2096     2096              
  Branches      365      365              
==========================================
+ Hits         1223     1230       +7     
+ Misses        788      783       -5     
+ Partials       85       83       -2     
Flag Coverage Δ
unittests 58.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta
Copy link
Collaborator Author

@effigies @oesteban Please review, thanks.

@jhlegarreta
Copy link
Collaborator Author

Contributon checks issues are expected: re #114 (comment)

@jhlegarreta jhlegarreta merged commit 60fd854 into nipreps:main May 15, 2024
21 of 22 checks passed
@jhlegarreta jhlegarreta deleted the FixStyleInUpdateAuthors branch May 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant