Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Consistently use matplotlib.colormaps in mpl namespace #104

Merged
merged 1 commit into from
May 8, 2024

Conversation

effigies
Copy link
Member

@effigies effigies commented May 8, 2024

A cm.get_cmap() snuck in since #98. To make clear that colormaps is not a local dictionary, I'm switching to using it from the mpl namespace.

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.30%. Comparing base (977f26a) to head (cc92be4).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
nireports/reportlets/mosaic.py 50.00% 2 Missing ⚠️
nireports/reportlets/nuisance.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   58.43%   58.30%   -0.14%     
==========================================
  Files          22       22              
  Lines        2086     2084       -2     
  Branches      364      321      -43     
==========================================
- Hits         1219     1215       -4     
- Misses        783      786       +3     
+ Partials       84       83       -1     
Flag Coverage Δ
unittests 58.30% <70.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhlegarreta
Copy link
Collaborator

Codecov failure is unrelated. Merging.

@jhlegarreta jhlegarreta merged commit 441bf34 into nipreps:main May 8, 2024
20 of 21 checks passed
@effigies effigies deleted the fix/consistent-colormaps branch May 8, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants