Subprocess error handling #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teps
A better solution using the latest version of Conch, would be something like:
@(:exit-code (command {:out *out* :redirect-err true :verbose true}))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're plenty of things that can go wrong during the compilation of protobuf:
javax.tools.ToolProvider/getSystemJavaCompilerwill yieldnil(even if the OpenJDK is installed and javac is in the PATH... I get this issue on Fedora but not on Ubuntu)thus, it'd be better to fail fast and report errors when they happen.
lein-protobuf currently doesn't even output at all the stderr of
./configureandmake.The first commit does it, but by printing the commands output when they exit. In the second commit I updated
conch, but there seems to still be some issues with the output buffering and the change is slightly more invasive.I chose to avoid printing the stderr right away, and print it only at the end if the command failed, but maybe it'd be better to just print a generic error message after the full output.