Fix typos #489
Merged
Fix typos #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Revert changes to BitcoinJS.js and OpenGSN.js. The changes are not immediately obvious in the minified code, and merging it would require thoroughly checking all changes, and updating the file hashes in the build script. Not worth the effort and/or risk. - Apply one typo fix made in HTML also to the English translation source strings. - Remove some outdated comments altogether. - Fix an additional typo.
danimoh
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Hello @rex4539. Thanks for this.
Some remarks for our other reviewers:
I added a commit with the following changes:
- Revert changes to BitcoinJS.js and OpenGSN.js. The changes are not immediately
obvious in the minified code, and merging it would require thoroughly checking
all changes, and updating the file hashes in the build script. Not worth the
effort and/or risk. - Apply one typo fix made in HTML also to the English translation source strings.
- Remove some outdated comments altogether.
- Fix an additional typo.
Related to this PR also an interesting discussion regarding automated typo detection and airdrop farming via PRs: privacy-scaling-explorations/sonobe#76
Just for reference. Not meant as an accusation.
sisou
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.