Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep all tags #50

Closed
wants to merge 6 commits into from
Closed

Commits on Sep 17, 2024

  1. add keep_all_tags parameter

    defaults to FALSE for continuity with existing uses of the module. Enables user to bypass the default stripping of unsupported tags for use in applications in which other services perform anonymization.
    ryder-cobean-nih committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b79a656 View commit details
    Browse the repository at this point in the history
  2. fix line breaks

    ryder-cobean-nih committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    50a533c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    6e5b76a View commit details
    Browse the repository at this point in the history
  2. simplify control flow in _read_dcm_pydicom

    introduce function _get_string_representation() which returns the string representation of a data element with proper error handling, and simplify definition of the _keyword_to_copy list based on whether keep_all_tags is True
    ryder-cobean-nih committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    94f2391 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. definition of the _keyword_to_copy list has been simplified based o…

    …n whether the `keep_all_tags` parameter is True. Remove overwrite of _keyword_to_copy, Also make sure to copy out keys in case that image is RGB and keep_all_tags is True
    ryder-cobean-nih committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1f17902 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. in _read_dcm_pydicom, copy tags from the data element itself rather t…

    …han keywords (resolves edge case in which a keyword is missing in the image with the tag present). Resolved issue of reusing variable.
    
    When keep_all_tags is true, the tags still need to be copied from img to out when calling srgb2gray. This is now resolved.
    ryder-cobean-nih committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    42e0c01 View commit details
    Browse the repository at this point in the history