Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fill types #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fill types #834

wants to merge 1 commit into from

Conversation

k10wl
Copy link

@k10wl k10wl commented Dec 26, 2022

Fix for mismatch types for fill types

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Documentations states that objects can have fill option as either string or ShapeFillOption, but it was not typed.
rel: https://nhn.github.io/tui.image-editor/latest/ShapeFillOption


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants