Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: h2 wrap instead of scroll. #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

css: h2 wrap instead of scroll. #90

wants to merge 2 commits into from

Conversation

lcrilly
Copy link
Collaborator

@lcrilly lcrilly commented Oct 9, 2024

Previously, h2 would scroll horizontally to accommodate very long page titles, such as ngx_http_random_index_module. This is effective but some browsers always display scrollbars, even when the title does not overflow.

As it is not possible to treat underscore as a wrappable character with the current content generator, we now wrap very long words (mid-word) when necessary. This only applies to the longest of module names (as above).

Closes #49

@nanaya
Copy link

nanaya commented Oct 10, 2024

Fwiw there's overflow-wrap: break-word which will only break long words.

@lcrilly
Copy link
Collaborator Author

lcrilly commented Oct 10, 2024

@nanaya thank you - this is great.

@pluknet
Copy link
Collaborator

pluknet commented Oct 10, 2024

Please mention browser(s) experiencing the problem in the commit message (considering that nginx will outlive github).

@pluknet
Copy link
Collaborator

pluknet commented Oct 10, 2024

@lcrilly I'm not CSS expert, just note that "word-break: break-word" is different from "overflow-wrap: break-word" mentioned in #90 (comment). (Also the former is marked deprecated on MDN).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White scroll bars appear in dark mode in Blink on macOS
3 participants