Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-20.0] Fix handling of end call for everyone with external signaling #4372

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 23, 2024

Backport of PR #4371

When the message applies to all participants the property is all in
lower case. The comparison is case sensitive, so the message was ignored
and the call was not left by the Talk Android app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@backportbot backportbot bot requested review from mahibi and danxuliu October 23, 2024 13:02
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: ☎️ call labels Oct 23, 2024
@backportbot backportbot bot added this to the 20.0.3 milestone Oct 23, 2024
@mahibi mahibi enabled auto-merge October 23, 2024 13:03
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4372-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9496
Errors132132

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

@mahibi mahibi merged commit 39fd745 into stable-20.0 Oct 23, 2024
12 of 15 checks passed
@mahibi mahibi deleted the backport/4371/stable-20.0 branch October 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: ☎️ call
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants