bruteforce #12066
bruteforce #12066
Conversation
Signed-off-by: jameskimmel <17176225+jameskimmel@users.noreply.github.com>
| @@ -72,14 +72,14 @@ Activating | |||
| ~~~~~~~~~~ | |||
|
|
|||
| Brute force protection is enabled by default on Nextcloud. Its behavior can be adjusted through the | |||
| ``bruteforcesettings`` app (shipped with Server and enabled by default), several ``occ`` commands, and several | |||
| ``bruteforcesettings`` app, several ``occ`` commands, and several | |||
There was a problem hiding this comment.
| ``bruteforcesettings`` app, several ``occ`` commands, and several | |
| ``bruteforcesettings`` app (shipped with Server, but disabled by default), several ``occ`` commands, and several |
| ``config.php`` parameters. Its effectiveness is highly dependent on having a properly configured environment, | ||
| particularly when integrating a reverse proxy with Nextcloud (and associated parameters such as ``trusted_proxies``). | ||
|
|
||
| The brute force settings app | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| This app, which shipped and enabled by default, makes it possible (via the Web UI) to view the status of a | ||
| This app makes it possible (via the Web UI) to view the status of a |
There was a problem hiding this comment.
| This app makes it possible (via the Web UI) to view the status of a | |
| This app (once enabled) makes it possible (via the Web UI) to view the status of a |
|
Though maybe we should have this enabled by default anyhow. :-) Either way, docs should be updated to reflect current behavior. Thanks for sending this in! |
|
You are very welcome, and thank you for taking a look. I enabled it today for testing but disabled it again since I don't see any use case for me. Is there no setting besides the whitelist? |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Since the app is now shipped and enabled by default in 30+ close this and send it against 29? |
Sorry, I don't know how stuff like this works here. Should I close the issue, since it is resolved in 30? |
|
/backport! to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/12066/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7c389f1a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/12066/stable29Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
No problem, I can do that for you |
☑️ Resolves