v2 with userInfo #4600
Open
v2 with userInfo #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11087.apk |
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11087 |
Codacy432Lint
SpotBugs (new)
SpotBugs (master)
Android-library is not set to master branch in build.gradle |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
| * {@link String} with the display name retrieved from the server. | ||
| * Call {@link RemoteOperationResult#getData()}.get(0) to get it. | ||
| */ | ||
| @Override | ||
| @Deprecated |
There was a problem hiding this comment.
If it is deprecated it should still work, so this just leads to an exception at runtime, so removing the method (leading to a compiler error) would be preferable imho.
What do you think @ezaquarii ?
tobiasKaminsky
force-pushed
the
v2withActivity
branch
from
a8f4dc9
to
a14318f
Compare
tobiasKaminsky
force-pushed
the
v2withActivity
branch
from
3223f18
to
6eb4ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #4900 and uses new GetUserInfoRemoteOperation