[CLN] - Clean up documentation within test code #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhammonds
approved these changes
Jan 22, 2021
|
awesome, thanks for the review @ryanhammonds! I'll merge this through when #230 is done |
|
Because I messed up the base here, I have re-added the relevant commits to #251. Closing this now, and will merge the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick sweep, cleaning up of mostly documentation in the test code.
Main updates:
@ryanhammonds - tagging you in just for a super quick sanity check, but this should be mostly procedural!
Edit: I did a dumb and branched from the
rhythmbranch. To save having to rebase, I just switched the merge target to be therhythmbranch. If you want to throw an eye on this, and let me know if it looks good, then I'll coordinate merging it with the rhythm branch.