Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanya explanations #384

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Vanya explanations #384

wants to merge 26 commits into from

Conversation

VanyaBK
Copy link
Collaborator

@VanyaBK VanyaBK commented Dec 3, 2023

Description

Added explanation column to the dataset generation and modified the prompt templates to include explanations

References

Chain-of-thought prompting

Blocked by

  • NA

Copy link
Collaborator

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this!

I think that using explanations should probably be optional though. It's not the same as what we did in the prompt2model paper, and I'm not convinced that it will be useful in all cases. I know this is a pretty big change to this PR (and I don't suggest this lightly), but could you please consider adding a flag that makes it possible to either use or not use explanations? Thank you!


input_col: str
explain_col: str
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that we just call this explanation_col to be consistent. Also, it's not clear what an explanation is. I'd suggest that you expand the docstring and describe what all the variables are.

Suggested change
explain_col: str
explanation_col: str

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants